[BIOMAGE-2001] Fix gene selection error and reload #780
Conversation
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 473 473
Lines 8064 8066 +2
Branches 1564 1566 +2
=======================================
+ Hits 6762 6764 +2
Misses 1244 1244
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
| @@ -190,6 +192,8 @@ const DotPlotPage = (props) => { | |||
| }; | |||
|
|
|||
| const deleteData = (genes) => { | |||
| if (!plotData) return; | |||
There was a problem hiding this comment.
Will this even be executed if theres no plotData - nothing to delete right? So maybe this is redundant?
There was a problem hiding this comment.
This executes when returning to the dot plot when there is an error loading the plot data, due to for example the work request timing out. I ran into this due to some problems with the worker in staging, where the plot data wouldn't load and editing the tree threw errors.
Description
If plot data fails to load,
plotDatais undefined and an error is thrown when selected genes are re-ordered or deleted. Add checks to skip if 'plotData' is undefined.When exiting to data-management and returning to the dot plot, check to skip loading initial genes as selected genes was not working correctly, because it was triggered while data was loading.
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-2001
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
#759
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional